DRM: Fix KEY_UPDATE_ERROR by not translating it into a KEY_LOAD_ERROR
#1670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ROR` We had kind of a dumb mistake where an error arising at license-communication time was falsely categorized as an error at license-fetching time. This is because we inadvertently also catched errors from the `MediaKeySession.prototype.update` EME call where we only intended to catch errors at the higher-up `getLicense` (the RxPlayer API) level. The fix to that issue is relatively straigtforward.
peaBerberian
added
bug
peaBerberian
commented
Mar 26, 2025
| async (licenseObject) => { | ||
| if (manualCanceller.isUsed()) { | ||
| return Promise.resolve(); | ||
| return; |
Collaborator
Author
There was a problem hiding this comment.
NOTE: removed because unnecessary
peaBerberian
commented
Mar 26, 2025
| } else { | ||
| try { | ||
| return updateSessionWithMessage(session, licenseObject); | ||
| await updateSessionWithMessage(session, licenseObject); |
Collaborator
Author
There was a problem hiding this comment.
NOTE: awaited to make the try / catch catch rejections, not just errors thrown synchronously. Also, we don't actually care about the returned value
peaBerberian
commented
Mar 26, 2025
| } | ||
| } | ||
| }) | ||
| .catch((err: unknown) => { |
Collaborator
Author
There was a problem hiding this comment.
The idea is to now do licenseFetchingPromise.then(onSucceed, onFailure) instead of: licenseFetchingPromise.then(onSucceed).catch(onFailure).
|
✅ Automated performance checks have passed on commit DetailsPerformance tests 1st run outputNo significative change in performance for tests:
|
Florent-Bouisset
approved these changes
Mar 27, 2025
This was referenced Mar 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had kind of a dumb mistake where an error arising at license-communication time was falsely categorized as an error at license-fetching time.
This is because we inadvertently also catched errors from the
MediaKeySession.prototype.updateEME call where we only intended to catch errors at the higher-upgetLicense(the RxPlayer API) level.The fix to that issue is relatively straigtforward.