Skip to content

Conversation

@Florent-Bouisset
Copy link
Collaborator

Some devices (such as meta quest 3) does not support ec-3 codec when the content is encrypted.
We already have a mechanism to verify that a codec is supported with EME APIs.
I have added the ec-3 codec to the list of codec to check by default.

@github-actions
Copy link

Automated performance checks have been performed on commit b34bf90abe7ef7a29b5db4016808cfdd1b090e86 with the base branch dev.

Tests results

✅ Tests have passed.

Performance tests 1st run output

No significative change in performance for tests:

Name Mean Median
loading 19.81ms -> 19.88ms (-0.072ms, z: 1.25865) 27.30ms -> 27.30ms
seeking 18.17ms -> 14.14ms (4.027ms, z: 0.63692) 11.45ms -> 11.55ms
audio-track-reload 27.31ms -> 27.33ms (-0.014ms, z: 0.73325) 39.60ms -> 39.75ms
cold loading multithread 48.51ms -> 47.85ms (0.666ms, z: 12.43038) 70.95ms -> 69.45ms
seeking multithread 25.35ms -> 24.00ms (1.351ms, z: 0.00363) 10.50ms -> 10.50ms
audio-track-reload multithread 26.86ms -> 26.95ms (-0.092ms, z: 0.66546) 39.45ms -> 39.45ms
hot loading multithread 16.73ms -> 16.51ms (0.219ms, z: 3.08174) 24.30ms -> 24.00ms

If you want to skip performance checks for latter commits, add the skip-performance-checks label to this Pull Request.

@peaBerberian peaBerberian added the Priority: 1 (High) This issue or PR has a high priority. label Mar 17, 2025
@peaBerberian peaBerberian added this to the 4.3.0 milestone Mar 17, 2025
@peaBerberian peaBerberian merged commit c125a64 into dev Mar 17, 2025
11 checks passed
@peaBerberian peaBerberian mentioned this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority: 1 (High) This issue or PR has a high priority.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants