Fix typo which prevented MediaKeys reusage and fix corresponding eslint rule #1615
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt rule I saw a very unfortunate typo which seems to prevent the RxPlayer from re-using a `MediaKeys` instance between contents sometimes (all the time? to check) since the v4.2.0. I saw that issue while continuing my work on integration tests in the massive #1478 PR. I thought our linter's [strict-boolean-expressions](https://typescript-eslint.io/rules/strict-boolean-expressions/) protected us against those types of typos but it turns out that for some weird reason the persons implementing that rule thought that numbers, strings and nullable object were OK (I just learned that, and I cannot understand why they thought it would be a good idea for a rule called **strict-boolean-expressions** grrrrr). So I fixed that rule, and BIM, multiple typos/missed post-refacto issues were all over the code. Thankfully, it doesn't seem to have created issues other than the aforementioned one.
peaBerberian
added
bug
Florent-Bouisset
approved these changes
Jan 6, 2025
This was referenced Mar 27, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I saw a very unfortunate typo which seems to prevent the RxPlayer from re-using a
MediaKeysinstance between contents sometimes (excepted on some identified platforms: xbox, playstation, smart TVs etc.) since the v4.2.0.I saw that issue while continuing my work on integration tests in the massive #1478 PR.
I thought our linter's
strict-boolean-expressionsrule protected us against those types of typos but it turns out that for some weird reason the persons implementing that rule thought that numbers, strings and nullable objects were OK (I just learned that, and I cannot understand why they thought it would be a good default behavior for a rule called strict-boolean-expressions with documentationForbids usage of non-boolean types in expressions where a boolean is expectedgrrrrr).So I fixed that rule, and BIM, multiple typos/missed post-refacto issues were all over the code.
Thankfully, it doesn't seem to have created issues other than the aforementioned one.