Reuse cache even if key system type given in API is not the same #1611
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks to the PR #1478, that basically allows integration tests on our DRM logic without a real encrypted or decodable contents nor MSE/EME available, I noticed that I very recently brought a minor regression in the rewrite of the `MediaKeySystemAccess` cache reusage rules. We relied on the `keySystems[].type` API to see if the cached one was compatible to the new wanted one, we probably wanted to compare the former with the `type` actually provided as argument to the `navigator.requestMediaKeySystemAccess` API instead (e.g. `keySystems[].type` could be set just to `widevine`, in which case the RxPlayer will probably ask for `com.widevine.alpha` instead). Thankfully, EME defines a [`MediaKeySystemAccess.prototype.keySystem`](https://www.w3.org/TR/encrypted-media-2/#dom-navigator-requestmediakeysystemaccess) property that seems to (according to that recommendation) always be equal to the asked `keySystem`.
peaBerberian
force-pushed
the
fix/same-key-system-type-cache
branch
from
192bf78 to
8aec1c3
Compare
Florent-Bouisset
approved these changes
Jan 7, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to the PR #1478, that basically allows integration tests on our DRM logic without a real encrypted or decodable contents nor MSE/EME available, I noticed that I very recently brought a minor regression in the rewrite of the
MediaKeySystemAccesscache reusage rules (not yet released).We relied on the
keySystems[].typeAPI to see if the cached one was compatible to the new wanted one, we probably wanted to compare the former with thetypeactually provided as argument to thenavigator.requestMediaKeySystemAccessAPI instead (e.g.keySystems[].typecould be set just towidevine, in which case the RxPlayer will probably ask forcom.widevine.alphainstead).Thankfully, EME defines a
MediaKeySystemAccess.prototype.keySystemproperty that seems to always be equal to the askedkeySystem.