Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 43 additions & 8 deletions src/compat/__tests__/can_reuse_media_keys.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,10 +8,14 @@ describe("Compat - canReuseMediaKeys", () => {
jest.resetModules();
});

it("should return true on any browser but WebOS", () => {
it("should return true on most browsers", () => {
jest.mock("../browser_detection", () => {
return { __esModule: true as const,
isWebOs: false };
return {
__esModule: true as const,
isWebOs: false,
isPhilipsNetTv: false,
isPanasonic: false,
};
});
const canReuseMediaKeys =
jest.requireActual("../can_reuse_media_keys.ts");
Expand All @@ -20,12 +24,43 @@ describe("Compat - canReuseMediaKeys", () => {

it("should return false on WebOs", () => {
jest.mock("../browser_detection", () => {
return { __esModule: true as const,
isWebOs: true,
isWebOs2022: false };
return {
__esModule: true as const,
isWebOs: true,
isWebOs2022: false,
isPanasonic: false,
isPhilipsNetTv: false,
};
});
const canReuseMediaKeys =
jest.requireActual("../can_reuse_media_keys.ts");
const canReuseMediaKeys = jest.requireActual("../can_reuse_media_keys.ts");
expect(canReuseMediaKeys.default()).toBe(false);
});

it("should return false on Panasonic", () => {
jest.mock("../browser_detection", () => {
return {
__esModule: true as const,
isWebOs: false,
isWebOs2022: false,
isPanasonic: true,
isPhilipsNetTv: false,
};
});
const canReuseMediaKeys = jest.requireActual("../can_reuse_media_keys.ts");
expect(canReuseMediaKeys.default()).toBe(false);
});

it("should return false on Philips' NETTV", () => {
jest.mock("../browser_detection", () => {
return {
__esModule: true as const,
isWebOs: false,
isWebOs2022: false,
isPanasonic: false,
isPhilipsNetTv: true,
};
});
const canReuseMediaKeys = jest.requireActual("../can_reuse_media_keys.ts");
expect(canReuseMediaKeys.default()).toBe(false);
});
});
9 changes: 9 additions & 0 deletions src/compat/browser_detection.ts
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ let isWebOs2022 = false;
/** `true` for Panasonic devices. */
let isPanasonic = false;

/** `true` we're relying on Philips's NetTv browser. */
let isPhilipsNetTv = false;

/** `true` for the PlayStation 5 game console. */
let isPlayStation5 = false;

Expand Down Expand Up @@ -143,6 +146,11 @@ let isXbox = false;
) {
isWebOs2021 = true;
}
} else if (
navigator.userAgent.indexOf("NETTV") !== -1 &&
navigator.userAgent.indexOf("Philips") !== -1
) {
isPhilipsNetTv = true;
} else if (/[Pp]anasonic/.test(navigator.userAgent)) {
isPanasonic = true;
} else if (navigator.userAgent.indexOf("Xbox") !== -1) {
Expand All @@ -160,6 +168,7 @@ export {
isIEOrEdge,
isFirefox,
isPanasonic,
isPhilipsNetTv,
isPlayStation5,
isXbox,
isSafariDesktop,
Expand Down
7 changes: 5 additions & 2 deletions src/compat/can_reuse_media_keys.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import {
isPanasonic,
isPhilipsNetTv,
isWebOs,
} from "./browser_detection";

Expand All @@ -12,9 +13,11 @@ import {
* - (2022-11-21): WebOS (LG TVs), for some encrypted contents, just
* rebuffered indefinitely when loading a content already-loaded on the
* HTMLMediaElement.
* - (2024-08-23): Seen on Philips 2024 and 2023 in:
* https://github.com/canalplus/rx-player/issues/1464
*
* @returns {boolean}
*/
export default function canReuseMediaKeys() : boolean {
return !isWebOs && !isPanasonic;
export default function canReuseMediaKeys(): boolean {
return !isWebOs && !isPhilipsNetTv && !isPanasonic;
}