[v3] Fix auto-play on tizen when it starts on a discontinuity #1500
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In one of our recent updates on the initial seek and play, we appeared to have broken autoPlay on Samsung TVs when they started on a discontinuity. This is yet again an issue linked to those infamous Tizen seek-backs I love to complain about. The fix proposed here is to just call the HTML5 `play` API even if we appear to be rebuffering from the amount of buffered data in front of us on Tizen if it tells us that it actually have enough data to play through its `readyState` property. This shouldn't break things and seems logical. I hesitated doing the same fix for all targets but the `readyState` property is known to be sometimes wrong on some devices so I didn't.
peaBerberian
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In one of our recent updates on the initial seek and play, we appeared to have broken autoPlay on Samsung TVs when they started on a discontinuity.
This is yet again an issue linked to those infamous Tizen seek-backs I love to complain about.
The fix proposed here is to just call the HTML5
playAPI even if we appear to be rebuffering from the amount of buffered data in front of us on Tizen if it tells us that it actually have enough data to play through itsreadyStateproperty.This shouldn't break things and seems logical. I hesitated doing the same fix for all targets but the
readyStateproperty is known to be sometimes wrong on some devices so I didn't.NOTE: Maybe we can do the same thing on V4, even if this shouldn't be required there.