[v3] fix: subtitles blinking in low-latency mode #1447
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, subtitle parsing for fragmented media in .mp4 format presented issues when played in low latency due to multiple moof and mdat boxes. To resolve this, the .mp4 content is now split to ensure only one moof and mdat are present during parsing. This ensures correct parsing of subtitles.
Merged
peaBerberian
force-pushed
the
fix/subtitles-blinking2-v3
branch
from
1f733d7 to
3573b41
Compare
Florent-Bouisset
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an adaptation of #1416 for our legacy v3 versions, which still get some bug fixes backported from the v4