fix(safari): no longer stuck in buffering on safari iOS when video has attribute "playsinline" #1406
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s attribute "playsinline"
Collaborator
|
So, are we also fixing it in v4? - even if the issue hasn't been reproduced |
Collaborator
Author
The issue occurs in v4 if there is attribute |
Collaborator
Author
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When playing a content with Safari mobile on iOS (17.3.1), it
autoplayis false inloadVideoOptions, AND if the video element has attributeplaysinline, the video will be stuck in buffering and never reach theLOADEDstate.This PR fix the issue, and the content should be properly be
LOADED. TheLOADEDattribute don't rely anymore on having or not attributeplaysinline.relates to #1390