fix(safari): check seeking event type in addition to the videoElement state "seeking" #1405
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When seeking on the current position the video element trigger the
"seeking" event, but the seeking attribute of the video element itself
is either not updated or is already reset to `false` at the moment the
event "seeking" is received.
video.onseeking = () => {
// video.seeking attribute can be false
console.log("on seeking!", video.seeking)
}
Due to a recent change we are waiting for the attribute "video.seeking"
to be true. Checking that the event type correspond to a seeking event
fix the issue.
Florent-Bouisset
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
equivalent of #1404 for v4
This didn't cause a bug in v4 but for safety and code robustness I propose to back-port the fix from the v3 to the v4.