Clean dist directory when calling build:all script #1378
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@Florent-Bouisset noticed that some release published in the v4 had a `dist` directory with unnecessary v3-related artefacts inside. This is due to the fact that `/dist` was added to our `.gitignore` file (so it isn't tracked by git) and back-and-forth between v3 and v4 code means that the dist directory might end up having potentially v3 stuff. We could be adding those in the `.npmignore` to prevent them to be published to npm, but I guess it makes more sense to just clean-up the `dist` directory each time we redo the `build:all` script which re-build every files and directories inside that that directory (and which is the script we do before every release).
Florent-Bouisset
approved these changes
Feb 6, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Florent-Bouisset noticed that some release published in the v4 had a
distdirectory with unnecessary v3-related artefacts inside.This is due to the fact that
/distwas added to our.gitignorefile (so it isn't tracked by git) and back-and-forth between v3 and v4 code means that the dist directory might end up having potentially v3 stuff.We could be adding those in the
.npmignoreto prevent them to be published to npm, but I guess it makes more sense to just clean-up thedistdirectory each time we redo thebuild:allscript which re-build every files and directories inside that that directory (and which is the script we do before every release).