Make RxPaired support planned log format update #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We recently work in the RxPlayer toward more "formalized" logs: canalplus/rx-player#1717 This PR changes some logs and consequently might break some of RxPaired's "log processors". I've updated them in two ways: 1. I've made them less resilient but supporting both the older and newer syntax more explicitly. This both to help avoiding false positives (other logs being processed by mistake) and to improve perf (e.g. by checking that a log begins by some specific string before further processing). 2. I now filter the timestamp and log severity (e.g. "warn", "info" etc. before calling the log processor, so the "log line" is just the log itself, making it easier to process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently work in the RxPlayer toward more "formalized" logs: canalplus/rx-player#1717
This PR changes some logs and consequently might break some of RxPaired's "log processors".
I've updated them in two ways:
I've made them less resilient but supporting both the older and newer syntax more explicitly. This both to help avoiding false positives (other logs being processed by mistake) and to improve perf (e.g. by checking that a log begins by some specific string before further processing).
I now filter the timestamp and log severity (e.g. "warn", "info" etc. before calling the log processor, so the "log line" is just the log itself, making it easier to process)