Fallback to HTTP POST when WebSocket aren't available #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We encounter several devices on which WebSocket are not available / are blocked.
This PR implements a fallback to HTTP POST-based log reporting when the WebSocket connection establishement does not succeed.
The idea for now is that the client send logs to the RxPaired server through HTTP POST every 2/3 seconds.
To divide messages sent in bulk between one another, those are sent as a JSON array in chronological order.
This adds many complexities especially on the server, as now the lifetime of a token might be unclear: is the device still using its token or not? With a WebSocket we just checked the connection state (and did keepalive ping-pong messages), when based on HTTP POST, we now rely on a timeout without any message, for now set to 30 seconds.
For now it's not possible to use
sendInstructionwhen a device relies on HTTP POST. It could theoretically be done through several means including Server-Sent-Events and long polling, but I did not bother for now.