client: set LogFormat = "full" on the RxPlayer class if one #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once canalplus/rx-player#1469 is merged, there will be a difference between debug logs enabled because of the global `__RX_PLAYER_DEBUG_MODE__` boolean and those because the RxPlayer class was passed as an argument to the global `__RX_INSPECTOR_RUN__` function (generally the former is relied on when the RxPlayer is not yet loaded and the latter whne it is). This commit fixes that difference: full logs in all cases. Alternatively, we could inside the RxPlayer just regularly re-check for the global `RX_PLAYER_DEBUG_MODE__` boolean which might make everything simpler.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once canalplus/rx-player#1469 is merged, there will be a difference between debug logs enabled because of the global
__RX_PLAYER_DEBUG_MODE__boolean and those because the RxPlayer class was passed as an argument to the global__RX_INSPECTOR_RUN__function (generally the former is relied on when the RxPlayer is not yet loaded and the latter whne it is).This PR fixes that difference: full logs in all cases.
Alternatively, we could inside the RxPlayer just regularly re-check for the global
RX_PLAYER_DEBUG_MODE__boolean which might make everything simpler.