fix: support 'charset=utf-8' parameter for application/json mimetype #175
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seeing the charset param for application/json content-type present in the wild, which was causing a strum error to be thrown when trying to construct the MediaTypes enum from the header. Following the existing solution above in the enum this simply adds a second 'serialize' attribute param to the ApplicationJson variant. It is noted that steveeJ added a 'TODO' to find a generic way to handle these on the existing usage, but this is not addressed in this bugfix.
Contributor
Author
|
Ah, i just noticed that this is a duplicate of #113 which I somehow missed. So I will close this and comment there. |
Contributor
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seeing the charset param for application/json content-type present in the wild (in this case Azure CR), which was causing a strum error to be thrown when trying to construct the
MediaTypesenum from the header.Following the existing solution above in the enum this simply adds a second 'serialize' attribute param to the ApplicationJson variant.
It is noted that @steveej added a 'TODO' to find a generic way to handle these on the existing usage, but this is not addressed in this bugfix.