Skip to content

feat(io): Support Context-Aware Histidine Salt Bridge Protonation#18

Merged
TKanX merged 6 commits intomainfrom
feature/17-support-bio-forge-salt-bridge-detection-for-context-aware-histidine-protonation
Feb 17, 2026
Merged

feat(io): Support Context-Aware Histidine Salt Bridge Protonation#18
TKanX merged 6 commits intomainfrom
feature/17-support-bio-forge-salt-bridge-detection-for-context-aware-histidine-protonation

Conversation

@TKanX
Copy link
Member

@TKanX TKanX commented Feb 17, 2026

Summary:

Updated dreid-forge to leverage the salt bridge detection capabilities introduced in bio-forge v0.4.0. This enhancement allows for context-aware histidine protonation, where histidine residues near carboxylate anions (ASP⁻, GLU⁻, C-terminal COO⁻) are automatically assigned the doubly-protonated HIP form to model stabilizing salt bridge interactions. This behavior is enabled by default but can be disabled via configuration.

Changes:

  • Updated Dependency:

    • Upgraded bio-forge to version 0.4.0.
  • Enhanced Protonation Configuration:

    • Added his_salt_bridge field to ProtonationConfig in src/io/mod.rs (defaults to true).
    • Updated to_bf_hydro_config in src/io/util.rs to pass this setting to the bio-forge engine.
  • Updated CLI:

    • Added --no-his-salt-bridge flag to dforge bio to optionally disable this feature.
    • Updated CLI configuration builder in src/bin/dforge/config/bio.rs.
    • Refined progress reporting in src/bin/dforge/commands/bio.rs to indicate salt bridge detection status.
  • Documentation:

    • Updated MANUAL.md with the new CLI flag documentation.
    • Updated ARCHITECTURE.md to reflect the new capability in the protonation stage description.
    • Added RustDoc comments explaining the salt bridge logic in ProtonationConfig.

@TKanX TKanX self-assigned this Feb 17, 2026
Copilot AI review requested due to automatic review settings February 17, 2026 09:28
@TKanX TKanX added documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request labels Feb 17, 2026
@TKanX TKanX linked an issue Feb 17, 2026 that may be closed by this pull request
21 tasks
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates dreid-forge’s biomolecular protonation pipeline to use bio-forge v0.4.0’s salt-bridge-aware histidine handling, allowing automatic HIS→HIP assignment near carboxylate anions (enabled by default, configurable/disableable via CLI).

Changes:

  • Bump bio-forge dependency to 0.4.0 and plumb new salt-bridge toggle into the hydro/protonation config conversion.
  • Add his_salt_bridge to ProtonationConfig (default true) and expose --no-his-salt-bridge CLI flag.
  • Update CLI progress text and documentation to reflect the new capability.

Reviewed changes

Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
Cargo.toml Upgrades bio-forge dependency to 0.4.0.
src/io/mod.rs Adds his_salt_bridge to ProtonationConfig with docs + default behavior.
src/io/util.rs Passes the new toggle into bf::ops::HydroConfig and extends tests.
src/bin/dforge/cli.rs Adds --no-his-salt-bridge CLI flag.
src/bin/dforge/config/bio.rs Maps CLI option into ProtonationConfig.his_salt_bridge.
src/bin/dforge/commands/bio.rs Updates progress substep text to reflect salt-bridge behavior.
MANUAL.md Documents the new CLI flag.
ARCHITECTURE.md Updates dependency/version references and protonation-stage description.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@TKanX TKanX merged commit 0457bc1 into main Feb 17, 2026
8 checks passed
@TKanX TKanX deleted the feature/17-support-bio-forge-salt-bridge-detection-for-context-aware-histidine-protonation branch February 17, 2026 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation 📖 Improvements or additions to documentation enhancement ✨ New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support bio-forge 0.4.0 Salt Bridge Detection for Context-Aware Histidine Protonation

2 participants