Conversation
…detection and bump bio-forge version to 0.4
21 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates dreid-forge’s biomolecular protonation pipeline to use bio-forge v0.4.0’s salt-bridge-aware histidine handling, allowing automatic HIS→HIP assignment near carboxylate anions (enabled by default, configurable/disableable via CLI).
Changes:
- Bump
bio-forgedependency to0.4.0and plumb new salt-bridge toggle into the hydro/protonation config conversion. - Add
his_salt_bridgetoProtonationConfig(defaulttrue) and expose--no-his-salt-bridgeCLI flag. - Update CLI progress text and documentation to reflect the new capability.
Reviewed changes
Copilot reviewed 5 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
Cargo.toml |
Upgrades bio-forge dependency to 0.4.0. |
src/io/mod.rs |
Adds his_salt_bridge to ProtonationConfig with docs + default behavior. |
src/io/util.rs |
Passes the new toggle into bf::ops::HydroConfig and extends tests. |
src/bin/dforge/cli.rs |
Adds --no-his-salt-bridge CLI flag. |
src/bin/dforge/config/bio.rs |
Maps CLI option into ProtonationConfig.his_salt_bridge. |
src/bin/dforge/commands/bio.rs |
Updates progress substep text to reflect salt-bridge behavior. |
MANUAL.md |
Documents the new CLI flag. |
ARCHITECTURE.md |
Updates dependency/version references and protonation-stage description. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Updated
dreid-forgeto leverage the salt bridge detection capabilities introduced inbio-forgev0.4.0. This enhancement allows for context-aware histidine protonation, where histidine residues near carboxylate anions (ASP⁻, GLU⁻, C-terminal COO⁻) are automatically assigned the doubly-protonated HIP form to model stabilizing salt bridge interactions. This behavior is enabled by default but can be disabled via configuration.Changes:
Updated Dependency:
bio-forgeto version0.4.0.Enhanced Protonation Configuration:
his_salt_bridgefield toProtonationConfiginsrc/io/mod.rs(defaults totrue).to_bf_hydro_configinsrc/io/util.rsto pass this setting to thebio-forgeengine.Updated CLI:
--no-his-salt-bridgeflag todforge bioto optionally disable this feature.src/bin/dforge/config/bio.rs.src/bin/dforge/commands/bio.rsto indicate salt bridge detection status.Documentation:
MANUAL.mdwith the new CLI flag documentation.ARCHITECTURE.mdto reflect the new capability in the protonation stage description.ProtonationConfig.