Skip to content

Modifications for tsql support#29

Merged
clausherther merged 2 commits into
calogica:mainfrom
b-per:modifications-for-tsql-support
Mar 26, 2021
Merged

Modifications for tsql support#29
clausherther merged 2 commits into
calogica:mainfrom
b-per:modifications-for-tsql-support

Conversation

@b-per
Copy link
Copy Markdown
Contributor

@b-per b-per commented Mar 26, 2021

Hi!

I have been working on a package to port this package to T-SQL.
Some of the macros require the adapter.dispatch call for me to able to override the default version.

If those changes are accepted I should be able to release dbt-expectations-tsql shortly.

Cheers,

b-per added 2 commits March 26, 2021 18:11
Required for overriding the macro for different adapters
Required for T-SQL whcih doesn't support booleans
Should work for all SQL languages
@clausherther clausherther self-requested a review March 26, 2021 13:40
Copy link
Copy Markdown
Contributor

@clausherther clausherther left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
Good idea to make those dispatch macros anyway. I'll probably have to go through and also do that for the rest of the tests to be more clean across the project, but will probably hold off until dbt 0.20 when some of the testing stuff changes in a bigger way (which will require rewrites).

@clausherther clausherther merged commit 0a64e5e into calogica:main Mar 26, 2021
@clausherther
Copy link
Copy Markdown
Contributor

@b-per you should see the new 0.2.8 on dbt-hub later today, or you can develop against main for now.
(same for your PR against dbt-date, which is now at 0.2.4)

@b-per
Copy link
Copy Markdown
Contributor Author

b-per commented Mar 27, 2021

Thanks @clausherther !

I have a bit of work to do on the README and the installation instructions but I have a first version of the T-SQL one here: https://github.com/b-per/dbt-expectations-tsql

I realised that tsql-utils and spark-utils don't mention dbt-utils in the root packages.yml, but they also use git submodules from dbt-utils. Do you know why this is the case? I have done the same but don't really understand the benefits.

I'll also need to think about how what mechanisms can be put in place to keep dbt-expectations-tsql with dbt-expectations when macros/integratio tests/integration models change in your repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants