fix: incorrectly resolving root #276
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
thymikee
commented
Apr 23, 2025
packages/cli/src/config.ts
Outdated
Comment on lines
46
to
47
| ownConfig.platforms[platform].autolinkingConfig[projectEntry] !== | ||
| undefined |
Contributor
Author
There was a problem hiding this comment.
adding this so that sourceDir is correctly displayed in the config command. RNC CLI removes the sourceDir from the output when it's explicitly undefined
thymikee
added a commit
that referenced
this pull request
Apr 28, 2025
* origin/main: feat: refactor and expose remote cache provider (#260) fix: move start from @react-native/community-cli-plugin (#288) fix: update gradle-wrapper (#287) fix: always use udid from matched device (#281) chore: v0.7.2 (#279) docs: Update migrating-from-community-cli.mdx (#284) docs: attribute @expo/fingerprint (#285) fix: support plugin in create-app chore: v0.7.1 (#278) fix: autolinking config missing project (#277) fix: bump template to v0.7.0 chore: cleanup ios brownfield android mention chore: v0.7.0 (#274) feat: upgrade templates to 0.79 (#275) fix: incorrectly resolving root (#276) chore: simplify welcome message and improve prompts (#273) docs: add logo (#272) chore: v0.6.2 (#268) fix: resolve project root to absolute path (#269)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We were incorrectly resolving root, relying on
process.cwd()instead of the one declared in the config or where the config file was resolved. AdjustedimportUpto return theconfigDirand using that as an automatically resolved root when not provided.This also reworks how
autolinkingConfigis working – we can now pass the entireprojectConfigunderprojectkey, which opens up the space for moving more autolinking logic into RNEFTest plan