Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions .changeset/famous-tips-lie.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
'@rnef/platform-apple-helpers': patch
'@rnef/platform-android': patch
'@rnef/config': patch
'@rnef/tools': patch
---

feat: refactor and expose remote cache provider
14 changes: 9 additions & 5 deletions packages/config/src/lib/schema.ts
Original file line number Diff line number Diff line change
Expand Up @@ -40,14 +40,18 @@ const ConfigTypeSchema = Joi.object({
plugins: Joi.array().items(Joi.function()).optional(),
platforms: Joi.object().pattern(Joi.string(), Joi.function()).optional(),
commands: Joi.array().items(CommandTypeSchema).optional(),
remoteCacheProvider: Joi.string().valid('github-actions', null).optional(),
remoteCacheProvider: Joi.string()
.valid('github-actions', null, Joi.function())
.optional(),
fingerprint: Joi.object({
extraSources: Joi.array().items(Joi.string()).default([]),
ignorePaths: Joi.array().items(Joi.string()).default([]),
}).default({
extraSources: [],
ignorePaths: [],
}).optional(),
})
.default({
extraSources: [],
ignorePaths: [],
})
.optional(),
}).unknown(false);

export { ConfigTypeSchema };

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,8 @@ import type {
} from '@react-native-community/cli-types';
import type { SupportedRemoteCacheProviders } from '@rnef/tools';
import {
fetchCachedBuild,
formatArtifactName,
intro,
isInteractive,
logger,
Expand All @@ -18,7 +20,6 @@ import { options } from '../buildAndroid/buildAndroid.js';
import { runGradle } from '../runGradle.js';
import { toPascalCase } from '../toPascalCase.js';
import { getDevices } from './adb.js';
import { fetchCachedBuild } from './fetchCachedBuild.js';
import type { DeviceData } from './listAndroidDevices.js';
import { listAndroidDevices } from './listAndroidDevices.js';
import { tryInstallAppOnDevice } from './tryInstallAppOnDevice.js';
Expand Down Expand Up @@ -59,12 +60,16 @@ export async function runAndroid(
const tasks = args.tasks ?? [`${mainTaskType}${toPascalCase(args.variant)}`];

if (!args.binaryPath && args.remoteCache) {
const cachedBuild = await fetchCachedBuild({
variant: args.variant,
remoteCacheProvider,
const artifactName = await formatArtifactName({
platform: 'android',
traits: [args.variant],
root: projectRoot,
fingerprintOptions,
});
const cachedBuild = await fetchCachedBuild({
artifactName,
remoteCacheProvider,
});
if (cachedBuild) {
// @todo replace with a more generic way to pass binary path
args.binaryPath = cachedBuild.binaryPath;
Expand Down
1 change: 0 additions & 1 deletion packages/platform-apple-helpers/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@
"adm-zip": "^0.5.16",
"fast-glob": "^3.3.2",
"fast-xml-parser": "^4.5.0",
"tar": "^7.4.3",
"tslib": "^2.3.0"
},
"devDependencies": {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@ import path from 'node:path';
import type { SupportedRemoteCacheProviders } from '@rnef/tools';
import {
color,
fetchCachedBuild,
formatArtifactName,
isInteractive,
logger,
promptSelect,
Expand All @@ -21,7 +23,6 @@ import {
getSimulatorPlatformSDK,
} from '../../utils/getPlatformInfo.js';
import { listDevicesAndSimulators } from '../../utils/listDevices.js';
import { fetchCachedBuild } from './fetchCachedBuild.js';
import { matchingDevice } from './matchingDevice.js';
import { cacheRecentDevice, sortByRecentDevices } from './recentDevices.js';
import { runOnDevice } from './runOnDevice.js';
Expand All @@ -39,13 +40,16 @@ export const createRun = async (
fingerprintOptions: { extraSources: string[]; ignorePaths: string[] }
) => {
if (!args.binaryPath && args.remoteCache) {
const cachedBuild = await fetchCachedBuild({
configuration: args.configuration ?? 'Debug',
distribution: args.destination ?? 'simulator',
remoteCacheProvider,
const artifactName = await formatArtifactName({
platform: 'ios',
traits: [args.destination ?? 'simulator', args.configuration ?? 'Debug'],
root: projectRoot,
fingerprintOptions,
});
const cachedBuild = await fetchCachedBuild({
artifactName,
remoteCacheProvider,
});
if (cachedBuild) {
// @todo replace with a more generic way to pass binary path
args.binaryPath = cachedBuild.binaryPath;
Expand Down
Loading