fix: translate location dropdown group labels and options in event-type settings

apps/web/public/static/locales/en/common.json

@@ -737,6 +737,7 @@
   "booking_reschedule_confirmation": "Reschedule your {{eventTypeTitle}} with {{profileName}}",
   "in_person_meeting": "In-person meeting",
   "in_person": "In Person (Organizer Address)",
+  "in_person_category": "In person",
   "link_meeting": "Link meeting",
   "phone_number": "Phone number",
   "attendee_phone_number": "Attendee phone number",

apps/web/public/static/locales/fr/common.json

@@ -719,6 +719,7 @@
   "booking_reschedule_confirmation": "Replanifiez votre {{eventTypeTitle}} avec {{profileName}}",
   "in_person_meeting": "Rendez-vous en personne",
   "in_person": "En personne (adresse de l'organisateur)",
+  "in_person_category": "En personne",
   "link_meeting": "Rendez-vous avec lien",
   "phone_number": "Numéro de téléphone",
   "attendee_phone_number": "Numéro de téléphone du participant",

packages/app-store/locations.ts

@@ -1,20 +1,20 @@
 /**
  * TODO: Consolidate this file with BookingLocationService and add tests
  */
-import type { TFunction } from "i18next";
-import { isValidPhoneNumber } from "libphonenumber-js/max";
-import { z } from "zod";
 
 import { appStoreMetadata } from "@calcom/app-store/bookerAppsMetaData";
 import logger from "@calcom/lib/logger";
 import { BookingStatus } from "@calcom/prisma/enums";
 import type { Ensure, Optional } from "@calcom/types/utils";
+import type { TFunction } from "i18next";
+import { isValidPhoneNumber } from "libphonenumber-js/max";
+import { z } from "zod";
 
 import type { EventLocationTypeFromAppMeta } from "../types/App";
 import {
+  DailyLocationType as importedDailyLocationType,
   MeetLocationType as importedMeetLocationType,
   MSTeamsLocationType as importedMSTeamsLocationType,
-  DailyLocationType as importedDailyLocationType,
 } from "./constants";
 
 export const MeetLocationType = importedMeetLocationType;
@@ -26,7 +26,7 @@ export type DefaultEventLocationType = {
   type: DefaultEventLocationTypeEnum;
   label: string;
   messageForOrganizer: string;
-  category: "in person" | "conferencing" | "other" | "phone";
+  category: "in_person_category" | "conferencing" | "other" | "phone";
   linkType: "static";
   supportsCustomLabel?: boolean;
 
@@ -114,7 +114,7 @@ export const defaultLocations: DefaultEventLocationType[] = [
     attendeeInputPlaceholder: "enter_address",
     defaultValueVariable: "attendeeAddress",
     iconUrl: "/map-pin-dark.svg",
-    category: "in person",
+    category: "in_person_category",
     linkType: "static",
     supportsCustomLabel: true,
   },
@@ -143,7 +143,7 @@ export const defaultLocations: DefaultEventLocationType[] = [
     variable: "locationAddress",
     defaultValueVariable: "address",
     iconUrl: "/map-pin-dark.svg",
-    category: "in person",
+    category: "in_person_category",
     linkType: "static",
   },
   {
@@ -242,7 +242,7 @@ for (const [appName, meta] of Object.entries(appStoreMetadata)) {
     for (const [key, value] of Object.entries(location)) {
       if (typeof value === "string") {
         // eslint-disable-next-line @typescript-eslint/ban-ts-comment
-        // @ts-ignore
+        // @ts-expect-error
         location[key] = value.replace(/{SLUG}/g, meta.slug).replace(/{TITLE}/g, meta.name);
       }
     }
@@ -397,7 +397,7 @@ export const getLocationValueForDB = (
   eventLocations: LocationObject[]
 ) => {
   let bookingLocation = bookingLocationTypeOrValue;
-  let conferenceCredentialId: number | undefined = undefined;
+  let conferenceCredentialId: number | undefined;
 
   eventLocations.forEach((location) => {
     if (location.type === bookingLocationTypeOrValue) {
@@ -481,8 +481,8 @@ export const getTranslatedLocation = (
   const translatedLocation = location.type.startsWith("integrations:")
     ? eventLocationType.label
     : translateAbleKeys.includes(locationKey)
-    ? t(locationKey)
-    : locationKey;
+      ? t(locationKey)
+      : locationKey;
 
   return translatedLocation;
 };