feat: SMS workflow action for form triggers #3

apps/api/v2/src/modules/organizations/teams/workflows/controllers/org-team-workflows.controller.e2e-spec.ts

@@ -404,7 +404,7 @@ describe("OrganizationsTeamsWorkflowsController (E2E)", () => {
       invalidWorkflow.steps = [
         {
           stepNumber: 1,
-          action: "sms_number",
+          action: "cal_ai_phone_call",
           recipient: PHONE_NUMBER,
           template: REMINDER,
           verifiedPhoneId: verifiedPhoneId,

apps/api/v2/src/modules/workflows/inputs/create-form-workflow.ts

@@ -7,8 +7,12 @@ import {
   EMAIL_ADDRESS,
   EMAIL_ATTENDEE,
   FORM_ALLOWED_STEP_ACTIONS,
+  SMS_NUMBER,
   WorkflowEmailAddressStepDto,
   WorkflowEmailAttendeeStepDto,
+  WorkflowPhoneNumberStepDto,
+  WorkflowPhoneAttendeeStepDto,
+  SMS_ATTENDEE,
 } from "./workflow-step.input";
 import {
   RoutingFormWorkflowTriggerDto,
@@ -85,6 +89,8 @@ export class CreateFormWorkflowDto {
     oneOf: [
       { $ref: getSchemaPath(WorkflowEmailAddressStepDto) },
       { $ref: getSchemaPath(WorkflowEmailAttendeeStepDto) },
+      { $ref: getSchemaPath(WorkflowPhoneAttendeeStepDto) },
+      { $ref: getSchemaPath(WorkflowPhoneNumberStepDto) },
     ],
     type: "array",
   })
@@ -99,8 +105,15 @@ export class CreateFormWorkflowDto {
       subTypes: [
         { value: WorkflowEmailAddressStepDto, name: EMAIL_ADDRESS },
         { value: WorkflowEmailAttendeeStepDto, name: EMAIL_ATTENDEE },
+        { value: WorkflowPhoneAttendeeStepDto, name: SMS_ATTENDEE },
+        { value: WorkflowPhoneNumberStepDto, name: SMS_NUMBER },
       ],
     },
   })
-  steps!: (WorkflowEmailAddressStepDto | WorkflowEmailAttendeeStepDto)[];
+  steps!: (
+    | WorkflowEmailAddressStepDto
+    | WorkflowEmailAttendeeStepDto
+    | WorkflowPhoneAttendeeStepDto
+    | WorkflowPhoneNumberStepDto
+  )[];
 }

apps/api/v2/src/modules/workflows/inputs/update-form-workflow.input.ts

@@ -8,6 +8,8 @@ import {
   EMAIL_ADDRESS,
   EMAIL_ATTENDEE,
   FORM_ALLOWED_STEP_ACTIONS,
+  SMS_ATTENDEE,
+  SMS_NUMBER,
   UpdateEmailAddressWorkflowStepDto,
   UpdateEmailAttendeeWorkflowStepDto,
   UpdateEmailHostWorkflowStepDto,
@@ -75,6 +77,8 @@ export class UpdateFormWorkflowDto {
     oneOf: [
       { $ref: getSchemaPath(UpdateEmailAddressWorkflowStepDto) },
       { $ref: getSchemaPath(UpdateEmailAttendeeWorkflowStepDto) },
+      { $ref: getSchemaPath(UpdatePhoneAttendeeWorkflowStepDto) },
+      { $ref: getSchemaPath(UpdatePhoneNumberWorkflowStepDto) },
     ],
     type: "array",
   })
@@ -90,8 +94,15 @@ export class UpdateFormWorkflowDto {
       subTypes: [
         { value: UpdateEmailAddressWorkflowStepDto, name: EMAIL_ADDRESS },
         { value: UpdateEmailAttendeeWorkflowStepDto, name: EMAIL_ATTENDEE },
+        { value: UpdatePhoneAttendeeWorkflowStepDto, name: SMS_ATTENDEE },
+        { value: UpdatePhoneNumberWorkflowStepDto, name: SMS_NUMBER },
       ],
     },
   })
-  steps?: (UpdateEmailAddressWorkflowStepDto | UpdateEmailAttendeeWorkflowStepDto)[];
+  steps?: (
+    | UpdateEmailAddressWorkflowStepDto
+    | UpdateEmailAttendeeWorkflowStepDto
+    | UpdatePhoneNumberWorkflowStepDto
+    | UpdatePhoneAttendeeWorkflowStepDto
+  )[];
 }

apps/api/v2/src/modules/workflows/inputs/workflow-step.input.ts

@@ -24,7 +24,7 @@ export const STEP_ACTIONS = [
   CAL_AI_PHONE_CALL,
 ] as const;
 
-export const FORM_ALLOWED_STEP_ACTIONS = [EMAIL_ATTENDEE, EMAIL_ADDRESS] as const;
+export const FORM_ALLOWED_STEP_ACTIONS = [EMAIL_ATTENDEE, EMAIL_ADDRESS, SMS_ATTENDEE, SMS_NUMBER] as const;
 
 export const STEP_ACTIONS_TO_ENUM = {
   [EMAIL_HOST]: WorkflowActions.EMAIL_HOST,

apps/web/public/static/locales/en/common.json

@@ -1460,6 +1460,7 @@
   "email_host_action": "send email to host",
   "email_attendee_action": "send email to attendees",
   "email_attendee_action_form": "Send email to submitted email address",
+  "sms_attendee_action_form": "Send SMS to submitted phone number",
   "sms_attendee_action": "Send SMS to attendee",
   "sms_number_action": "send SMS to a specific number",
   "send_reminder_sms": "Easily send meeting reminders via SMS to your attendees",

packages/features/ee/workflows/api/scheduleSMSReminders.ts

@@ -171,11 +171,7 @@ export async function handler(req: NextRequest) {
       }
 
       if (message?.length && message?.length > 0 && sendTo) {
-        const smsMessageWithoutOptOut = message;
-
-        if (process.env.TWILIO_OPT_OUT_ENABLED === "true") {
-          message = await WorkflowOptOutService.addOptOutMessage(message, locale || "en");
-        }
+        const smsMessageWithoutOptOut = await WorkflowOptOutService.addOptOutMessage(message, locale || "en");
 
         const scheduledNotification = await scheduleSmsOrFallbackEmail({
           twilioData: {

packages/features/ee/workflows/components/WorkflowDetailsPage.tsx

@@ -79,6 +79,8 @@ export default function WorkflowDetailsPage(props: Props) {
           if (isFormTrigger(form.getValues("trigger"))) {
             if (option.value === WorkflowActions.EMAIL_ATTENDEE) {
               label = t("email_attendee_action_form");
+            } else if (option.value === WorkflowActions.SMS_ATTENDEE) {
+              label = t("sms_attendee_action_form");
             }
           }
 
@@ -167,11 +169,11 @@ export default function WorkflowDetailsPage(props: Props) {
     <>
       <div>
         <FormCard
-          className="border-muted mb-0"
+          className="mb-0 border-muted"
           collapsible={false}
           label={
-            <div className="flex items-center gap-2 pb-2 pt-1">
-              <div className="border-subtle text-subtle ml-1 rounded-lg border p-1">
+            <div className="flex gap-2 items-center pt-1 pb-2">
+              <div className="p-1 ml-1 rounded-lg border border-subtle text-subtle">
                 <Icon name="zap" size="16" />
               </div>
               <div className="text-sm font-medium leading-none">{t("trigger")}</div>
@@ -208,11 +210,11 @@ export default function WorkflowDetailsPage(props: Props) {
                 <div key={index}>
                   <FormCard
                     key={step.id}
-                    className="bg-muted border-muted mb-0"
+                    className="mb-0 bg-muted border-muted"
                     collapsible={false}
                     label={
-                      <div className="flex items-center gap-2 pb-2 pt-1">
-                        <div className="border-subtle text-subtle rounded-lg border p-1">
+                      <div className="flex gap-2 items-center pt-1 pb-2">
+                        <div className="p-1 rounded-lg border border-subtle text-subtle">
                           <Icon name="arrow-right" size="16" />
                         </div>
                         <div className="text-sm font-medium leading-none">{t("action")}</div>

packages/features/ee/workflows/components/WorkflowStepContainer.tsx

@@ -380,11 +380,10 @@ export default function WorkflowStepContainer(props: WorkflowStepProps) {
   });
 
   const hasAiAction = hasCalAIAction(steps);
-  const hasSMSAction = steps.some((s) => isSMSAction(s.action));
-  const hasWhatsappAction = steps.some((s) => isWhatsappAction(s.action));
   const hasEmailToHostAction = steps.some((s) => s.action === WorkflowActions.EMAIL_HOST);
+  const hasWhatsappAction = steps.some((s) => isWhatsappAction(s.action));
 
-  const disallowFormTriggers = hasAiAction || hasSMSAction || hasEmailToHostAction || hasWhatsappAction;
+  const disallowFormTriggers = hasAiAction || hasEmailToHostAction || hasWhatsappAction;
 
   const filteredTriggerOptions = triggerOptions.filter(
     (option) => !(isFormTrigger(option.value) && disallowFormTriggers)

packages/features/ee/workflows/lib/constants.ts

@@ -108,4 +108,6 @@ export const FORM_TRIGGER_WORKFLOW_EVENTS: WorkflowTriggerEvents[] = [
 export const ALLOWED_FORM_WORKFLOW_ACTIONS = [
   WorkflowActions.EMAIL_ATTENDEE,
   WorkflowActions.EMAIL_ADDRESS,
+  WorkflowActions.SMS_ATTENDEE,
+  WorkflowActions.SMS_NUMBER,
 ] as const;

packages/features/ee/workflows/lib/reminders/emailReminderManager.ts

@@ -340,6 +340,7 @@ const scheduleEmailReminderForEvt = async (args: scheduleEmailReminderArgs & { e
   });
 };
 
+// sends all immediately, no scheduling needed
 const scheduleEmailReminderForForm = async (
   args: scheduleEmailReminderArgs & {
     formData: FormSubmissionData;

packages/features/ee/workflows/lib/reminders/reminderScheduler.ts

@@ -114,10 +114,6 @@ const processWorkflowStep = async (
   };
 
   if (isSMSAction(step.action)) {
-    if (!evt) {
-      // SMS action not not yet supported for form triggers
-      return;
-    }
     const sendTo = step.action === WorkflowActions.SMS_ATTENDEE ? smsReminderNumber : step.sendTo;
 
     await scheduleSMSReminder({
@@ -127,7 +123,7 @@ const processWorkflowStep = async (
       message: step.reminderBody || "",
       sender: step.sender,
       isVerificationPending: step.numberVerificationPending,
-      evt,
+      ...contextData,
     });
   } else if (
     step.action === WorkflowActions.EMAIL_ATTENDEE ||