Skip to content

fix: Allow install on teams for concurrent meeting apps #23429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
joeauyeung merged 4 commits into from
Aug 29, 2025
Merged

fix: Allow install on teams for concurrent meeting apps #23429

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
68ffde6
Allow install on teams for concurrent meeting apps
joeauyeung Aug 28, 2025
260c96b
Install concurrent meeting apps on app card
joeauyeung Aug 28, 2025
c64f198
Allow installAbleOnTeams on installation page
joeauyeung Aug 28, 2025
9d5bd28
Fix logic check
joeauyeung Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/components/apps/AppPage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,7 @@ export const AppPage = ({

const handleAppInstall = () => {
setIsLoading(true);
if (isConferencing(categories)) {
if (isConferencing(categories) && !concurrentMeetings) {
mutation.mutate({
type,
variant,
Expand Down
2 changes: 1 addition & 1 deletion apps/web/lib/apps/installation/[[...step]]/getServerSideProps.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ export const getServerSideProps = async (context: GetServerSidePropsContext) =>
isConferencing,
isOrg,
// conferencing apps dont support team install
installableOnTeams: !isConferencing,
installableOnTeams: !appMetadata?.concurrentMeetings || !isConferencing,
} as OnboardingPageProps,
};
};
2 changes: 1 addition & 1 deletion packages/features/apps/components/AppCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ export function AppCard({ app, credentials, searchText, userAdminTeams }: AppCar
}, [app.name, searchText]);

const handleAppInstall = () => {
if (isConferencing(app.categories)) {
if (isConferencing(app.categories) && !app.concurrentMeetings) {
mutation.mutate({
type: app.type,
variant: app.variant,
Expand Down
Loading