chore: remove unused code including /api/nope
#23323
Conversation
Walkthrough
Possibly related PRs
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. 📜 Recent review detailsConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro 💡 Knowledge Base configuration:
You can enable these sources in your CodeRabbit configuration. 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (08/25/25)1 reviewer was added to this PR based on Keith Williams's automation. |
dosubot
bot
added
the
performance
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
apps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx (1)
55-60: Fix: Avoid indefinite loader on metadata parse failureIf user metadata fails zod parsing, the component returns StepConnectionLoader and never recovers, leading to a stuck UI. Fallback to proceeding without metadata instead of rendering a perpetual loader.
Apply this diff:
- const result = userMetadata.safeParse(user.metadata); - if (!result.success) { - return <StepConnectionLoader />; - } - const { data: metadata } = result; + const result = userMetadata.safeParse(user.metadata); + const metadata = result.success ? result.data : undefined;
🧹 Nitpick comments (3)
apps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx (3)
67-67: Use stable/unique key for list itemsitem.name may be non-unique or mutable. Prefer slug for React list keys to reduce unnecessary re-renders and avoid key collisions.
- <li key={item.name}> + <li key={item.slug}>
62-65: Minor: Simplify null checks around itemsYou can rely on optional chaining with items?.map to avoid repeating queryConnectedVideoApps?.items.
- {queryConnectedVideoApps?.items && - queryConnectedVideoApps?.items.map((item) => { + {queryConnectedVideoApps?.items?.map((item) => {
12-14: Avoid magic string for excluded slugHardcoding "daily-video" makes future changes brittle. Hoist into a typed constant for clarity and reusability.
Add the constant near the top:
import { AppConnectionItem } from "../components/AppConnectionItem"; import { StepConnectionLoader } from "../components/StepConnectionLoader"; +const EXCLUDED_VIDEO_APP_SLUGS = new Set(["daily-video"] as const);Use it in the filter:
- if (item.slug === "daily-video") return null; // we dont want to show daily here as it is installed by default + if (EXCLUDED_VIDEO_APP_SLUGS.has(item.slug)) return null; // excluded: installed by defaultAlso applies to: 65-65
📜 Review details
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
apps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx(1 hunks)apps/web/components/plain/PlainContactForm.tsx(0 hunks)
💤 Files with no reviewable changes (1)
- apps/web/components/plain/PlainContactForm.tsx
🧰 Additional context used
📓 Path-based instructions (3)
**/*.tsx
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Always use
t()for text localization in frontend code; direct text embedding should trigger a warning
Files:
apps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx
**/*.{ts,tsx}
📄 CodeRabbit inference engine (.cursor/rules/review.mdc)
Flag excessive Day.js use in performance-critical code; prefer native Date or Day.js
.utc()in hot paths like loops
Files:
apps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx
**/*.{ts,tsx,js,jsx}
⚙️ CodeRabbit configuration file
Flag default exports and encourage named exports. Named exports provide better tree-shaking, easier refactoring, and clearer imports. Exempt main components like pages, layouts, and components that serve as the primary export of a module.
Files:
apps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx
⏰ Context from checks skipped due to timeout of 180000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
- GitHub Check: Install dependencies / Yarn install & cache
🔇 Additional comments (2)
apps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx (2)
105-106: Localization usage looks goodButton label uses t(), and there’s no user-facing hardcoded text. This complies with the frontend localization guideline.
94-94: ✅ Prop removal verified – no lingeringtorTFunctionreferences
Confirmed thatConnectedVideoStepInneris invoked without atprop, and there are no remainingt:prop definitions,TFunctiontypes, or related imports inapps/web/components/getting-started/steps-views/ConnectedVideoStep.tsx. The cleanup aligns with the PR goal of trimming unused APIs and has no functional impact.
| import { Popover, PopoverContent, PopoverTrigger } from "@calcom/ui/components/popover"; | ||
| import { showToast } from "@calcom/ui/components/toast"; | ||
|
|
||
| interface ContactFormData { |
| const [hasAnyInstalledVideoApps, setAnyInstalledVideoApps] = useState(false); | ||
| return ( | ||
| <> | ||
| <ConnectedVideoStepInner setAnyInstalledVideoApps={setAnyInstalledVideoApps} t={t} user={user} /> |
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
hbjORbj
changed the title
/api/nope
E2E results are ready! |
What does this PR do?
Mandatory Tasks (DO NOT REMOVE)