Skip to content

Conversation

@supalarry
Copy link
Contributor

@supalarry supalarry commented Jul 10, 2025

Linear CAL-6076


Summary by cubic

Added support for hidden event types in the v2 API, allowing event types to be marked as hidden and excluded from public endpoints.

  • New Features
    • Added a hidden field to event type creation, update, and output types.
    • Public /v2/event-types endpoint now excludes hidden event types.
    • Authenticated users can access all their event types, including hidden ones, via a new /v2/event-types/all endpoint.
    • Updated tests to cover hidden event type behavior.

@supalarry supalarry requested a review from a team July 10, 2025 15:47
@supalarry supalarry requested a review from a team as a code owner July 10, 2025 15:47
@vercel
Copy link

vercel bot commented Jul 10, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
cal Ignored Ignored Sep 4, 2025 9:08am
cal-eu Ignored Ignored Sep 4, 2025 9:08am

@linear
Copy link

linear bot commented Jul 10, 2025

@graphite-app graphite-app bot requested a review from a team July 10, 2025 15:47
@keithwillcode keithwillcode added core area: core, team members only platform Anything related to our platform plan labels Jul 10, 2025
@dosubot dosubot bot added event-types area: event types, event-types 💻 refactor labels Jul 10, 2025
@delve-auditor
Copy link

delve-auditor bot commented Jul 10, 2025

No security or compliance issues detected. Reviewed everything up to 82bcc81.

Security Overview
  • 🔎 Scanned files: 9 changed file(s)
Detected Code Changes

The diff is too large to display a summary of code changes.

Reply to this PR with @delve-auditor followed by a description of what change you want and we'll auto-submit a change to this PR to implement it.

@graphite-app
Copy link

graphite-app bot commented Jul 10, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (07/10/25)

1 reviewer was added to this PR based on Keith Williams's automation.

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cubic found 2 issues across 9 files. Review them in cubic.dev

React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.

userId,
hidden: false,
},
include: { users: true, schedule: true, destinationCalendar: true },
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using include here will select all columns from the eventType table and related tables, which can lead to performance overhead and unnecessary data exposure. Use select to explicitly specify only the required fields instead of include.

Suggested change
include: { users: true, schedule: true, destinationCalendar: true },
select: { users: true, schedule: true, destinationCalendar: true },

@supalarry
Copy link
Contributor Author

Don't merge without my approval - need to inform users because it's a breaking change.

@github-actions
Copy link
Contributor

This PR is being marked as stale due to inactivity.

@github-actions github-actions bot added the Stale label Jul 25, 2025
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Jul 25, 2025

Note

Other AI code review bot(s) detected

CodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review.

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch lauris/cal-6076-feat-hidden-event-types-v2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore or @coderabbit ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@supalarry
Copy link
Contributor Author

PR #23584 will fix this

@supalarry supalarry closed this Sep 4, 2025
@supalarry supalarry deleted the lauris/cal-6076-feat-hidden-event-types-v2 branch September 4, 2025 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core area: core, team members only event-types area: event types, event-types platform Anything related to our platform plan 💻 refactor size/L Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants