-
Notifications
You must be signed in to change notification settings - Fork 11.6k
refactor: v2 api hidden event types #22390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
|
✅ No security or compliance issues detected. Reviewed everything up to 82bcc81. Security Overview
Detected Code ChangesThe diff is too large to display a summary of code changes. Reply to this PR with |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (07/10/25)1 reviewer was added to this PR based on Keith Williams's automation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cubic found 2 issues across 9 files. Review them in cubic.dev
React with 👍 or 👎 to teach cubic. Tag @cubic-dev-ai to give specific feedback.
| userId, | ||
| hidden: false, | ||
| }, | ||
| include: { users: true, schedule: true, destinationCalendar: true }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using include here will select all columns from the eventType table and related tables, which can lead to performance overhead and unnecessary data exposure. Use select to explicitly specify only the required fields instead of include.
| include: { users: true, schedule: true, destinationCalendar: true }, | |
| select: { users: true, schedule: true, destinationCalendar: true }, |
|
Don't merge without my approval - need to inform users because it's a breaking change. |
|
This PR is being marked as stale due to inactivity. |
|
Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing Touches🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
Status, Documentation and Community
|
|
PR #23584 will fix this |
Linear CAL-6076
Summary by cubic
Added support for hidden event types in the v2 API, allowing event types to be marked as hidden and excluded from public endpoints.
hiddenfield to event type creation, update, and output types./v2/event-typesendpoint now excludes hidden event types./v2/event-types/allendpoint.