refactor: handleNewBooking #5 #17094
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
keithwillcode
added
core
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
packages/features/bookings/lib/handleNewBooking/getEventType.ts
Outdated
Show resolved
Hide resolved
Contributor
|
This PR is being marked as stale due to inactivity. |
dosubot
bot
added
bookings
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (11/18/24)1 reviewer was added to this PR based on Keith Williams's automation. |
Udit-takkar
commented
Nov 18, 2024
Comment on lines
-1561
to
-1567
| if (isConfirmedByDefault) { | ||
| const subscribersMeetingEnded = await getWebhooks(subscriberOptionsMeetingEnded); | ||
| const subscribersMeetingStarted = await getWebhooks(subscriberOptionsMeetingStarted); | ||
|
|
||
| let deleteWebhookScheduledTriggerPromise: Promise<unknown> = Promise.resolve(); | ||
| const scheduleTriggerPromises = []; | ||
|
|
Contributor
Author
There was a problem hiding this comment.
moved all the scheduling logic to a single funciton
Udit-takkar
commented
Nov 18, 2024
Comment on lines
-859
to
-860
| const workflows = await getAllWorkflowsFromEventType(eventType, organizerUser.id); | ||
|
|
Contributor
Author
There was a problem hiding this comment.
just moved it up
Contributor
|
This PR is being marked as stale due to inactivity. |
Contributor
|
This PR is being marked as stale due to inactivity. |
Contributor
Author
|
Too many conflicts. I'll have to break this down into smaller PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Continuing refactor of handleNewBooking
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?