Skip to content

Conversation

@zomars
Copy link
Contributor

@zomars zomars commented Apr 9, 2024

What does this PR do?

Follow up for #13621

Since we're aiming to migrate to app router. It's not very explicit that we should avoid using next-router. This eslint rule aims to make it pretty clear.

image

Type of change

  • Chore (refactoring code, technical debt, workflow improvements)

How should this be tested?

  • yarn lint

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

@graphite-app graphite-app bot requested a review from a team April 9, 2024 22:24
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@keithwillcode keithwillcode added api area: API, enterprise API, access token, OAuth core area: core, team members only foundation labels Apr 9, 2024
@dosubot dosubot bot added platform Anything related to our platform plan 💻 refactor labels Apr 9, 2024
@graphite-app
Copy link

graphite-app bot commented Apr 9, 2024

Graphite Automations

"Add foundation team as reviewer" took an action on this PR • (04/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add platform team as reviewer" took an action on this PR • (04/09/24)

1 reviewer was added to this PR based on Keith Williams's automation.

@graphite-app graphite-app bot requested a review from a team April 9, 2024 22:25
Copy link
Contributor Author

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Self review done

@zomars zomars changed the title add: deprecated-imports-next-router chore: Adds deprecated-imports-next-router Apr 9, 2024
@vercel
Copy link

vercel bot commented Apr 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 10:34pm
cal ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 10:34pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 10:34pm
qa ⬜️ Ignored (Inspect) Visit Preview Apr 9, 2024 10:34pm

@zomars zomars enabled auto-merge (squash) April 9, 2024 22:34
@github-actions
Copy link
Contributor

github-actions bot commented Apr 9, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@deploysentinel
Copy link

deploysentinel bot commented Apr 9, 2024

Current Playwright Test Results Summary

✅ 301 Passing - ⚠️ 9 Flaky

Run may still be in progress, this comment will be updated as current testing workflow or job completes...

(Last updated on 04/09/2024 10:47:40pm UTC)

Run Details

Running Workflow PR Update on Github Actions

Commit: 3e62216

Started: 04/09/2024 10:44:20pm UTC

⚠️ Flakes

📄   apps/web/playwright/availability.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Availablity Can manage single schedule
Retry 2Retry 1Initial Attempt
1.20% (4) 4 / 332 runs
failed over last 7 days
18.67% (62) 62 / 332 runs
flaked over last 7 days

📄   apps/web/playwright/profile.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Update Profile Can resend verification link if the secondary email is unverified
Retry 1Initial Attempt
3.88% (13) 13 / 335 runs
failed over last 7 days
14.63% (49) 49 / 335 runs
flaked over last 7 days

📄   apps/web/playwright/webhook.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2Retry 1Initial Attempt
0.60% (2) 2 / 335 runs
failed over last 7 days
24.48% (82) 82 / 335 runs
flaked over last 7 days

📄   apps/web/playwright/event-types.e2e.ts • 2 Flakes

Top 1 Common Error Messages

null

2 Test Cases Affected

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Event Types tests -- future user enabling recurring event comes with default options
Retry 1Initial Attempt
0% (0) 0 / 330 runs
failed over last 7 days
6.36% (21) 21 / 330 runs
flaked over last 7 days
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1Initial Attempt
0% (0) 0 / 328 runs
failed over last 7 days
3.35% (11) 11 / 328 runs
flaked over last 7 days

📄   apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done existing user migrated to an organization
Retry 1Initial Attempt
0% (0) 0 / 266 runs
failed over last 7 days
3.01% (8) 8 / 266 runs
flaked over last 7 days

📄   apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Stripe integration Paid booking should be able to be cancelled
Retry 1Initial Attempt
1.22% (4) 4 / 328 runs
failed over last 7 days
6.10% (20) 20 / 328 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Preview Preview - embed-core should load
Retry 1Initial Attempt
0% (0) 0 / 330 runs
failed over last 7 days
33.94% (112) 112 / 330 runs
flaked over last 7 days

📄   packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake

Test Case Results

Test Case Last 7 days Failures Last 7 days Flakes
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1Initial Attempt
0.61% (2) 2 / 330 runs
failed over last 7 days
52.73% (174) 174 / 330 runs
flaked over last 7 days

View Detailed Build Results


Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty solid rule

@zomars zomars merged commit f2eebe9 into main Apr 16, 2024
@zomars zomars deleted the chore/add-deprecated-imports-next-router branch April 16, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api area: API, enterprise API, access token, OAuth core area: core, team members only foundation platform Anything related to our platform plan 💻 refactor

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants