-
Notifications
You must be signed in to change notification settings - Fork 11.6k
chore: Adds deprecated-imports-next-router #14486
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
Graphite Automations"Add foundation team as reviewer" took an action on this PR • (04/09/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add platform team as reviewer" took an action on this PR • (04/09/24)1 reviewer was added to this PR based on Keith Williams's automation. |
zomars
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Self review done
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 4 Ignored Deployments
|
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 This PR introduced no changes to the JavaScript bundle! 🙌 |
Current Playwright Test Results Summary✅ 301 Passing - Run may still be in progress, this comment will be updated as current testing workflow or job completes... (Last updated on 04/09/2024 10:47:40pm UTC) Run DetailsRunning Workflow PR Update on Github Actions Commit: 3e62216 Started: 04/09/2024 10:44:20pm UTC
|
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Availablity Can manage single schedule
Retry 2 • Retry 1 • Initial Attempt |
1.20% (4)4 / 332 runsfailed over last 7 days |
18.67% (62)62 / 332 runsflaked over last 7 days |
📄 apps/web/playwright/profile.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Update Profile Can resend verification link if the secondary email is unverified
Retry 1 • Initial Attempt |
3.88% (13)13 / 335 runsfailed over last 7 days |
14.63% (49)49 / 335 runsflaked over last 7 days |
📄 apps/web/playwright/webhook.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
FORM_SUBMITTED on submitting team form, triggers team webhook
Retry 2 • Retry 1 • Initial Attempt |
0.60% (2)2 / 335 runsfailed over last 7 days |
24.48% (82)82 / 335 runsflaked over last 7 days |
📄 apps/web/playwright/event-types.e2e.ts • 2 Flakes
Top 1 Common Error Messages
|
|
2 Test Cases Affected |
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Event Types tests -- future user enabling recurring event comes with default options
Retry 1 • Initial Attempt |
0% (0)0 / 330 runsfailed over last 7 days |
6.36% (21)21 / 330 runsflaked over last 7 days |
|
Event Types tests -- future user Different Locations Tests Can add Link Meeting as location and book with it
Retry 1 • Initial Attempt |
0% (0)0 / 328 runsfailed over last 7 days |
3.35% (11)11 / 328 runsflaked over last 7 days |
📄 apps/web/playwright/organization/organization-invitation.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Organization Email matching orgAutoAcceptEmail and a Verified Organization with DNS Setup Done existing user migrated to an organization
Retry 1 • Initial Attempt |
0% (0)0 / 266 runsfailed over last 7 days |
3.01% (8)8 / 266 runsflaked over last 7 days |
📄 apps/web/playwright/integrations-stripe.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Stripe integration Paid booking should be able to be cancelled
Retry 1 • Initial Attempt |
1.22% (4)4 / 328 runsfailed over last 7 days |
6.10% (20)20 / 328 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/preview.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Preview Preview - embed-core should load
Retry 1 • Initial Attempt |
0% (0)0 / 330 runsfailed over last 7 days |
33.94% (112)112 / 330 runsflaked over last 7 days |
📄 packages/embeds/embed-core/playwright/tests/inline.e2e.ts • 1 Flake
Test Case Results
| Test Case | Last 7 days Failures | Last 7 days Flakes |
|---|---|---|
|
Inline Iframe Inline Iframe - Configured with Dark Theme
Retry 1 • Initial Attempt |
0.61% (2)2 / 330 runsfailed over last 7 days |
52.73% (174)174 / 330 runsflaked over last 7 days |
PeerRich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pretty solid rule
What does this PR do?
Follow up for #13621
Since we're aiming to migrate to app router. It's not very explicit that we should avoid using
next-router. This eslint rule aims to make it pretty clear.Type of change
How should this be tested?
Mandatory Tasks