change glob to adapter the .phar files #1042
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
As you can see, this change breaks our unit tests. You will need to fix those. I am unsure why you would embed migrations and seeds into the phar file as that would mean you couldn't add more migrations. If you can explain better what you are attempting to achieve by packaging your migrations, then maybe I can get a better understanding and see what is needed. |
Member
|
@jhonata-menezes Any update here regarding the tests? |
Author
|
I'll do the tests this week. |
Member
|
Closing as this seems abandoned. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When generating .phar file the glob function did not find the migrations, changing to DirectiryIterator it is possible to find the migrations.