(GH-598) Allow users to disable or override target framework path#607
Merged
gep13 merged 2 commits intocake-contrib:developfrom Aug 4, 2020
Merged
(GH-598) Allow users to disable or override target framework path#607gep13 merged 2 commits intocake-contrib:developfrom
gep13 merged 2 commits intocake-contrib:developfrom
Conversation
…meworkOverridePath In some cases, there is no need to use the TargetFrameworkOverridePath when building .NET Full Framework using .NET Core. This is especially true if the user already references the needed reference assemblies provided by Microsoft (which will also be the default in .NET Core 5.x).
…argetFrameworkOverridePath
Member
|
@AdmiringWorm your changes have been merged, thanks for your contribution 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases, there is no need to use the TargetFrameworkOverridePath when building .NET Full Framework using .NET Core. This is especially true if the user already references the needed reference assemblies provided by Microsoft (which will also be the default in .NET Core 5.x).
In other cases, we may resolve the wrong path to the mono library directory (especialy in cases where a custom directory is used), so allowing users to override the directory used is also useful.
resolves #598