Skip to content

GH3546: Add DotNetRestore alias (synonym to DotNetCoreRestore) #3619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2021
Merged

GH3546: Add DotNetRestore alias (synonym to DotNetCoreRestore) #3619

merged 1 commit into from
Oct 21, 2021

Conversation

@augustoproiete
Copy link
Member

@augustoproiete augustoproiete commented Oct 20, 2021

DotNetCore DotNet synonym
DotNetCoreRestore ➡️ 🆕 DotNetRestore
DotNetCoreRestoreSettings ➡️ 🆕 DotNetRestoreSettings
  • New DotNetRestore aliases are being introduced
  • DotNetRestore aliases contain the code of the existing DotNetCoreRestore (rename/move)
  • Existing DotNetCoreRestore aliases are forwarding calls to newly introduced DotNetRestore aliases
  • New DotNetRestoreSettings class is being introduced
  • DotNetRestoreSettings class contains the code of DotNetCoreRestoreSettings (rename/move)
  • The previous DotNetCoreRestoreSettings is now empty and inherits from the new DotNetRestoreSettings
  • Namespaces Cake.Common.Restore.DotNetCore.* have been preserved as to not introduce breaking changes
  • Unit Tests and Integration Tests remain the same, and call the old DotNetCore*** aliases, exercising the new DotNet*** aliases in the process

Closes #3546

@augustoproiete augustoproiete requested a review from a team October 20, 2021 04:15
nils-a
nils-a approved these changes Oct 20, 2021
View reviewed changes
Copy link
Member

@nils-a nils-a left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@augustoproiete augustoproiete merged commit 9d53cce into cake-build:develop Oct 21, 2021
@augustoproiete augustoproiete deleted the add-dotnet-restore-alias branch October 21, 2021 00:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nils-a nils-a nils-a approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add DotNetRestore alias (synonym to DotNetCoreRestore)

2 participants

@augustoproiete @nils-a