Skip to content

(GH-3282) Renamed GitVersionVerbosity values to match GitVersion #3321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 19, 2021
Merged

(GH-3282) Renamed GitVersionVerbosity values to match GitVersion #3321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/Cake.Common.Tests/Unit/Tools/GitVersion/GitVersionRunnerTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,11 +356,11 @@ public void Should_Tolerate_Bad_Json_Set()
}

[Theory]
[InlineData(GitVersionVerbosity.None, nameof(Verbosity.Quiet))]
[InlineData(GitVersionVerbosity.Debug, nameof(Verbosity.Diagnostic))]
[InlineData(GitVersionVerbosity.Info, nameof(Verbosity.Verbose))]
[InlineData(GitVersionVerbosity.Warn, nameof(Verbosity.Normal))]
[InlineData(GitVersionVerbosity.Error, nameof(Verbosity.Minimal))]
[InlineData(GitVersionVerbosity.Quiet, nameof(GitVersionVerbosity.Quiet))]
[InlineData(GitVersionVerbosity.Diagnostic, nameof(GitVersionVerbosity.Diagnostic))]
[InlineData(GitVersionVerbosity.Verbose, nameof(GitVersionVerbosity.Verbose))]
[InlineData(GitVersionVerbosity.Normal, nameof(GitVersionVerbosity.Normal))]
[InlineData(GitVersionVerbosity.Minimal, nameof(GitVersionVerbosity.Minimal))]
public void Should_Add_Verbosity_To_Arguments_If_Set(GitVersionVerbosity verbosity, string arg)
{
// Given
Expand Down
10 changes: 5 additions & 5 deletions src/Cake.Common/Tools/GitVersion/GitVersionRunner.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,23 +174,23 @@ private ProcessArgumentBuilder GetArguments(GitVersionSettings settings)
{
switch (settings.Verbosity.Value)
{
case GitVersionVerbosity.None:
case GitVersionVerbosity.Quiet:
builder.Append("-verbosity");
builder.Append(nameof(Verbosity.Quiet));
break;
case GitVersionVerbosity.Debug:
case GitVersionVerbosity.Diagnostic:
builder.Append("-verbosity");
builder.Append(nameof(Verbosity.Diagnostic));
break;
case GitVersionVerbosity.Info:
case GitVersionVerbosity.Verbose:
builder.Append("-verbosity");
builder.Append(nameof(Verbosity.Verbose));
break;
case GitVersionVerbosity.Warn:
case GitVersionVerbosity.Normal:
builder.Append("-verbosity");
builder.Append(nameof(Verbosity.Normal));
break;
case GitVersionVerbosity.Error:
case GitVersionVerbosity.Minimal:
builder.Append("-verbosity");
builder.Append(nameof(Verbosity.Minimal));
break;
Expand Down
22 changes: 11 additions & 11 deletions src/Cake.Common/Tools/GitVersion/GitVersionVerbosity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,33 +5,33 @@
namespace Cake.Common.Tools.GitVersion
{
/// <summary>
/// The GitVersion verbosity.
/// The GitVersion verbosity. Default is <see cref="Normal"/>.
/// </summary>
public enum GitVersionVerbosity
{
/// <summary>
/// No messages will be logged.
/// Quiet verbosity.
/// </summary>
None,
Quiet = 0,

/// <summary>
/// Log error messages.
/// Minimal verbosity.
/// </summary>
Error,
Minimal = 1,

/// <summary>
/// Log error and warning messages.
/// Normal verbosity (Default).
/// </summary>
Warn,
Normal = 2,

/// <summary>
/// Log error, warning and info messages.
/// Verbose verbosity.
/// </summary>
Info,
Verbose = 3,

/// <summary>
/// Log error, warning, info and debug messages (log all).
/// Diagnostic verbosity.
/// </summary>
Debug
Diagnostic = 4,
}
}