Skip to content

feat: support the "lockable http tarball" protocol #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
getchoo wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: support the "lockable http tarball" protocol #121

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/api/v1/forge/error.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ pub enum ForgeError {
BadRequest(String),
NoTarGz(String),
NoReleaseFound(String),
BadURI(String),
}

impl IntoResponse for ForgeError {
Expand Down Expand Up @@ -73,6 +74,13 @@ impl IntoResponse for ForgeError {
StatusCode::NOT_FOUND,
format!("Hi friend, no suitable releases found for {} :(", repo),
),
ForgeError::BadURI(uri) => {
error!("ForgeError::BadURI: {uri}");
(
StatusCode::INTERNAL_SERVER_ERROR,
format!("Hi friend, {} couldn't be converted to a valid URI :(", uri),
)
}
};
(status, error_message).into_response()
}
Expand Down
27 changes: 22 additions & 5 deletions src/api/v1/forge/handlers.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

use axum::{
extract::{Extension, OriginalUri, Path, Query},
http::Uri,
http::{HeaderValue, Uri},
response::{IntoResponse, Redirect, Response},
};
use serde::Deserialize;
Expand Down Expand Up @@ -78,6 +78,23 @@ where
}
}

pub fn redirect_to(redirect_url: &str) -> Result<Response, ForgeError> {
let mut response = Redirect::to(redirect_url).into_response();

// Support the "Lockable HTTP Tarball" protocol
// https://nix.dev/manual/nix/stable/protocols/tarball-fetcher.html
//
// This allows Nix to lock the URL we're redirecting to instead of the current endpoint (which
// may redirect to a different URL at another time)
let Ok(header_value) = HeaderValue::from_str(&format!("<{}>; rel=\"immutable\"", redirect_url))
else {
return Err(ForgeError::BadURI(redirect_url.to_string()));
};
response.headers_mut().insert("Link", header_value);

Ok(response)
}

pub async fn get_tarball_url_for_latest_release(
Path(paths): Path<HashMap<String, String>>,
Extension(forge): Extension<DynForge>,
Expand All @@ -101,7 +118,7 @@ pub async fn get_tarball_url_for_latest_release(
)
.await?;
trace!("tarball_url_for_latest_release: {redirect_url:}");
Ok(Redirect::to(&redirect_url).into_response())
Ok(redirect_to(&redirect_url)?)
}

#[derive(Deserialize, Debug)]
Expand Down Expand Up @@ -142,7 +159,7 @@ pub async fn get_tarball_url_for_semantic_version(
)
.await?;
trace!("tarball_url_for_semantic_version: {redirect_url}");
Ok(Redirect::to(&redirect_url).into_response())
Ok(redirect_to(&redirect_url)?)
}

pub async fn get_tarball_url_for_branch(
Expand All @@ -156,7 +173,7 @@ pub async fn get_tarball_url_for_branch(
.get_tarball_url_for_branch(&host, &user, &repo, &branch)
.await?;
trace!("tarball_url_for_branch: {url:}");
Ok(Redirect::to(&url).into_response())
Ok(redirect_to(&url)?)
}

pub async fn get_tarball_url_for_version(
Expand All @@ -170,5 +187,5 @@ pub async fn get_tarball_url_for_version(
.get_tarball_url_for_version(&host, &user, &repo, &version)
.await?;
trace!("tarball_url_for_version: {url:}");
Ok(Redirect::to(&url).into_response())
Ok(redirect_to(&url)?)
}