caddyhttp: Add server options keepalive_idle and keepalive_count#7298
caddyhttp: Add server options keepalive_idle and keepalive_count#7298mholt merged 4 commits intocaddyserver:masterfrom
keepalive_idle and keepalive_count#7298Conversation
…(keepalive_count) Signed-off-by: Joshua McBeth <[email protected]>
|
Upon further review of the recent change history and discussion I think this should also have a keepalive_enable bool parameter so all struct fields directly map and all behaviors are supported. |
Signed-off-by: Joshua McBeth <[email protected]>
|
Actually, I guess it should be keepalive_disable if the default behavior should be enable. This is reflected in the latest revision of the PR. |
|
I'm not sure I like that "disabled" is a separate option because this would be a breaking change for anyone already doing |
…en interval is negative Signed-off-by: Joshua McBeth <[email protected]>
|
Fair enough. I've reverted the keepalive_disable option and restored the keepalive_interval behavior for negative values. Since negative values for the count and idle parameters never had any other meaning, I've preserved the "underlying socket value unchanged" for negative values there for now. |
|
Thanks! I think some |
Signed-off-by: Joshua McBeth <[email protected]>
|
I updated the existing global_server_options_single.caddyfiletest to include the keepalive parameters. |
keepalive_idle and keepalive_count
This pull request adds keepalive_idle and keepalive_count per follow-up discussion in #7144.
Assistance Disclosure
No AI was used.