Merged
Conversation
Signed-off-by: Mohammed Al Sahaf <[email protected]>
Signed-off-by: Mohammed Al Sahaf <[email protected]>
Member
Author
|
Apparently we now don't like naked returns |
francislavoie
approved these changes
Sep 26, 2025
Member
francislavoie
left a comment
francislavoie
left a comment
There was a problem hiding this comment.
I think I prefer the explicit returns, yeah.
But can golangci please stop adding lints out of nowhere, thanks. 🤦♂️
Member
|
Naked returns can be useful in the sense that simpler code can mean less room for error (i.e. can't write the wrong variable name to return) -- but anyway, LGTM. Thanks for the patch! I keep forgetting the linters can change under our feet. |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assistance Disclosure
No AI was used.