reverseproxy: Only handle extended connect for websockets#6740
Merged
mholt merged 1 commit intocaddyserver:masterfrom Dec 11, 2024
Merged
reverseproxy: Only handle extended connect for websockets#6740mholt merged 1 commit intocaddyserver:masterfrom
mholt merged 1 commit intocaddyserver:masterfrom
Conversation
Contributor
Author
Member
|
LGTM, |
Contributor
Author
mholt
approved these changes
Dec 11, 2024
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Excellent, thank you! I mainly wanted @WeidiDeng 's approval first 😄
1 task
mohammed90
pushed a commit
to cedricziel/caddy
that referenced
this pull request
Aug 29, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC 8441 specifies that:
Otherwise we might end up modifying other use cases of the extended CONNECT method later on.