Skip to content

go.mod: upgrade only some otel deps#6676

Merged
francislavoie merged 1 commit intomasterfrom
fix-otel-issue
Nov 5, 2024
Merged

go.mod: upgrade only some otel deps#6676
francislavoie merged 1 commit intomasterfrom
fix-otel-issue

Conversation

@mohammed90
Copy link
Member

otel libs are notorious for incompatibility within themselves, and it isn't clear how to sync them properly. To fix the latest failure, I upgraded only otelhttp and otlptracegrpc and had them work themselves out on upgrading the others. I saw the same breakage when upgraded only otelhttp, then upgrading otlptracegrpc fixed it. Fingers crossed 🤞🏼

Signed-off-by: Mohammed Al Sahaf <[email protected]>
@mohammed90 mohammed90 added the CI/CD 🔩 Automated tests, releases label Nov 4, 2024
@francislavoie francislavoie enabled auto-merge (squash) November 5, 2024 00:10
@francislavoie francislavoie merged commit 91e3413 into master Nov 5, 2024
@francislavoie francislavoie deleted the fix-otel-issue branch November 5, 2024 00:10
@francislavoie
Copy link
Member

We'll see 🤷‍♂️

@mholt
Copy link
Member

mholt commented Nov 5, 2024

Thanks for this!

@mholt mholt added this to the v2.9.0-beta.3 milestone Nov 5, 2024
mohammed90 added a commit to cedricziel/caddy that referenced this pull request Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI/CD 🔩 Automated tests, releases

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants