ci: don't exit early on error in remote CI machine#6519
Merged
mohammed90 merged 1 commit intomasterfrom Aug 18, 2024
Merged
Conversation
Member
|
Ah, so this'll help prevent disk space depletion? Or if these are ephemeral instances do we need to do the cleanup? |
Member
Author
Yep, but it's just a copy of the repo at the subject commit, not that much.
It isn't an ephemeral machine. It's the IBM machine. |
Collaborator
|
Maybe should this be done only on IBM machines to prevent running useless steps on ephemeral containers in other cases? |
Member
Author
It is only on the IBM machine. It's in the s390x-test job. That job only runs on a specific machine. |
dunglas
approved these changes
Aug 18, 2024
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Actions shell scripts are loaded with
set -e, which tells the shell to exit at any error. The impact on our flow is missing the deletion step of the code for every failed CI run on the remote machine. This PR fixes it so No Files Left Behind.