Skip to content

reverseproxy: Add placeholder for networkAddr in active health check headers#6450

Merged
francislavoie merged 4 commits intocaddyserver:masterfrom
dylanschultzie:schultzie/target_dial
Jul 9, 2024
Merged

reverseproxy: Add placeholder for networkAddr in active health check headers#6450
francislavoie merged 4 commits intocaddyserver:masterfrom
dylanschultzie:schultzie/target_dial

Conversation

@dylanschultzie
Copy link
Contributor

Follows: #6440

Previously hostAddr would duplicate the Host header. This now appropriately passes the full original upstream:

5.0.0.33 - - [09/Jul/2024 15:35:04] "GET /health HTTP/1.1" 200 -
+Host: 5.0.0.33:53336
User-Agent: Go-http-client/1.1
+Full-Upstream: 5.0.0.33:8545
Accept-Encoding: gzip

Resolves forum post: https://caddy.community/t/can-you-pass-in-the-full-upstream-to-an-active-health-check/24718

@CLAassistant
Copy link

CLAassistant commented Jul 9, 2024

CLA assistant check
All committers have signed the CLA.

@francislavoie francislavoie added the feature ⚙️ New feature or request label Jul 9, 2024
@francislavoie francislavoie enabled auto-merge (squash) July 9, 2024 18:03
@francislavoie francislavoie merged commit 4943a4f into caddyserver:master Jul 9, 2024
@dylanschultzie dylanschultzie deleted the schultzie/target_dial branch July 9, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature ⚙️ New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants