fileserver: Remove newline characters from precomputed etags#6394
Merged
mholt merged 3 commits intocaddyserver:masterfrom Jun 19, 2024
Merged
fileserver: Remove newline characters from precomputed etags#6394mholt merged 3 commits intocaddyserver:masterfrom
mholt merged 3 commits intocaddyserver:masterfrom
Conversation
mohammed90
reviewed
Jun 13, 2024
mholt
reviewed
Jun 13, 2024
francislavoie
changed the title
armadi1809
force-pushed
the
aar-trim-newline-from-etags
branch
from
4d3a752 to
f161093
Compare
Contributor
Author
|
The replacement of the newline character is now done through |
mholt
reviewed
Jun 15, 2024
mholt
approved these changes
Jun 15, 2024
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Thanks! LGTM now. I just made one quick stylistic change (IMO there's no need to convert "" to []byte, so we can just use an empty byte slice.)
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes newline characters from etags acquired from precomputed files as per the discussion in #6222