logging: set file mode when the file already exist.#6391
Merged
mholt merged 1 commit intocaddyserver:masterfrom Jun 12, 2024
Merged
logging: set file mode when the file already exist.#6391mholt merged 1 commit intocaddyserver:masterfrom
mholt merged 1 commit intocaddyserver:masterfrom
Conversation
101d3e7 introduced a configuration option to set the log file mode. This option was not taken into account if the file already exists, making users having to delete their logs to have new logs created with the right mode.
ririsoft
referenced
this pull request
Jun 12, 2024
Commit 101d3e7 introduced file mode setting, but was missing a JSON Marshaller so that CaddyFile can be converted to JSON safely.
Contributor
Author
|
Documentation for the option submitted in caddyserver/website#399 |
mholt
approved these changes
Jun 12, 2024
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Thank you! Let's give it a try.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
101d3e7 introduced a configuration option to set the log file mode. This option was not taken into account if the file already exists, making users having to delete their logs to have new logs created with the right mode.
This was initially spotted in the discussion for 0bc27e5.
This will allow users to set the mode in CaddyFile and restart their server without the need to remove previous logs.
As suggested in the commit discussion I will open a separate PR to document that log files options require a server restart to be taken into account, when the log file destination does not change.