logging: Customizable zapcore.Core#6381
Conversation
|
Thanks for the contribution! Since we're teeing, I wonder if multiple cores (a slice of cores) would be worthwhile? Maybe not. Just thinking. If not, this looks pretty good and we can probably merge it after a quick review. (I think godoc comments will be needed) |
|
I think an output module is still always needed, right? So I guess you'd want to use This also needs Caddyfile support I think, and it would be nice if we could have somekind of mock core module that we can use for testing configuration etc. |
zapcore.Core
|
Thanks for the feedback, addressing comments . @mholt An implementation of this interface could chain up multiple cores if needed. I can add the doc strings. @francislavoie It uses the default logging core. If the user doesn't want additional output |
39bd590 to
50fa1a6
Compare
This change enables support custom
caddy.logging.coresthat implementzapcore.Corefor a sentry event reporting plugin that reports errors and their traces at github.com/kkroo/caddy-sentry