cmd: remove zealous check of Caddyfile auto-detection#6370
Merged
Conversation
Member
|
If only we had telemetry to know things like this 🙃 Thanks. Do we have a test case for the use case though? We should probably add one. |
Member
Author
Added. I have a feeling deep in my heart I might've missed some case or condition. What am I missing? |
Member
|
Hmm do we have a test case for any Caddyfile paths without |
Member
Author
|
Go 🚗 |
mholt
approved these changes
Jun 5, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out, it isn't uncommon to have
Caddyfile.prodand such (#6362 (comment)). This is mentioned on the website as:Source
Fixes #6373