Make it possible to configure the DisableStorageCheck setting for certmagic#6368
Merged
mholt merged 1 commit intocaddyserver:masterfrom Jun 4, 2024
Merged
Conversation
…ertmagic See discussion about this setting in caddyserver/certmagic#201
ankon
force-pushed
the
pr/disable-storage-check
branch
from
5b13f92 to
8997483
Compare
mholt
approved these changes
Jun 4, 2024
Member
mholt
left a comment
mholt
left a comment
There was a problem hiding this comment.
Nice, thanks. I hadn't quite gotten around to this (or it wasn't needed, can't remember). Anyway, I appreciate that it is marked as experimental. I want to improve storage checks so that they happen way less often, and maybe this won't be needed.
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See discussion about this setting in caddyserver/certmagic#201
Note that this doesn't expose the setting through the caddyfile, I guess that would have to happen just-about-here: https://github.com/framer/caddy/blob/5b13f9272454ea13105689fbe24a14b00421f901/caddyconfig/httpcaddyfile/tlsapp.go#L331-L334
Not sure whether that's wanted/needed, and if it is, how to best name it?
I did consider another idea of injecting some sort of "configuration adapter" here, which would take a certmagic config, do whatever it needs to do, and then return the adapted config. This could over the long term be nicer, especially for these kind of special options -- but it would also open the world to a lot more mischief. WDYT?