reverse_proxy: apply keep-alive setting for h2c requests#6343
Merged
Conversation
WeidiDeng
changed the title
WeidiDeng
changed the title
Member
|
Thanks Weidi! As I understand it, this depends on an upstream patch first? |
Member
Author
|
Yes, or else h2c will stop working if keep alive is disabled. For now it's buggy behaviour, but it works 🤷 . |
Member
Author
|
Just wait for the release of golang/x/net. It's fixed in the master. |
Member
|
Great! Will do 😄 |
mholt
approved these changes
Aug 8, 2024
Member
|
Great - thanks for the ping! And the patch :) |
1 task
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix 6342.