Fix pushing direction#37
Merged
diarmidmackenzie merged 1 commit intoJun 26, 2023
Merged
Conversation
Member
|
Thanks for this. I'm happy to merge this as it's clearly an improvement, and this is only test / example code. A completely correct fix would also allow for the fact that the entity being pushed may not be in world space, so we should use It would also be nice to fix up the Cannon version, which looks like it has the same issue. Further fixes for either of these would be much appreciated! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Ammo's force-pushable example, wherever I click an object, the force comes from (0, 0, 0).
I added vector subtraction to direct force from the clicker to the object. Also, this code works if cursor is mouse.