Skip to content

Conversation

@Elettrotecnica
Copy link
Contributor

Following from #4

Dear @vincentfretin,

here are the changes applied so far to my fork. One note: I introduced my own fork of lib-hubs in the dependencies because of Elettrotecnica/lib-hubs@94cb865. I could open a PR there as well for this, or you could fork lib-hubs into c-frame so it "stays in the family".

The current changes concerning NAF make it so that I can load a model on my non-NAF scene using the build from this PR, but I think it would be nice that NAF behavior on gltf-model-plus was somewhat more "pluggable". One way to do it could be to emit events during the inflation, rather than setting the components explicitly, then react to them somewhere else in our code. What do you think about it?

Ciao

@vincentfretin
Copy link
Member

For lib-hubs, as I said in #5 (comment) can you create a PR there, hubs is still using threer147 so the PlaneBufferGeometry warning should also be fixed there. If they don't merge it, we'll fork it in c-frame organization like you suggest.

For NAF, making it optional with just condition like you did is enough. Adding events and handling it elsewhere would make the code less understandable I think.

@vincentfretin vincentfretin merged commit 0b32b5a into c-frame:main Apr 24, 2024
@vincentfretin
Copy link
Member

I updated simple-navmesh-constraint to

<script src="https://cdn.jsdelivr.net/gh/AdaRoseCannon/aframe-xr-boilerplate@bca4792/simple-navmesh-constraint.js"></script>

in the examples in c2a0420

@vincentfretin
Copy link
Member

And also adding the component now :) 73e26f2

@Elettrotecnica Elettrotecnica deleted the upstream-contrib branch April 24, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants