Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following from #4
Dear @vincentfretin,
here are the changes applied so far to my fork. One note: I introduced my own fork of lib-hubs in the dependencies because of Elettrotecnica/lib-hubs@94cb865. I could open a PR there as well for this, or you could fork lib-hubs into c-frame so it "stays in the family".
The current changes concerning NAF make it so that I can load a model on my non-NAF scene using the build from this PR, but I think it would be nice that NAF behavior on gltf-model-plus was somewhat more "pluggable". One way to do it could be to emit events during the inflation, rather than setting the components explicitly, then react to them somewhere else in our code. What do you think about it?
Ciao