threejs r141 compatibility for movement-controls #377
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…141 compatibility (but still compatible with threejs r125 aframe 1.2.0)
|
It would be great to get this merged. I currently dependon aframe |
Member
Author
|
This PR is merged in the community fork #5 |
Member
Author
|
The changes are now also in this repo. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace
THREE.Math.degToRadbyTHREE.MathUtils.degToRadfor threejs r141 compatibility (aframe master). Note that this change is still compatible with threejs r125 aframe 1.2.0.cc @AdaRoseCannon because you use the movement-controls component in aframe-xr-boilerplate.
I also changed it in
lib/ColladaLoader.jsand inlib/FBXLoader.jsbut at one point it may be good to recopy the loaders fromthree/examples/js/loaders/ColladaLoader.jsandthree/examples/js/loaders/FBXLoader.js. There are maybe some fixes since then, but I don't know it's hard to compare the files.I didn't test all the components of this repository for threejs r141 compatibility, I fixed just the error I saw in the console with movement-controls component included in a project.