Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #686 +/- ##
=====================================
Coverage 7.98% 7.98%
=====================================
Files 313 313
Lines 10564 10564
Branches 2034 2034
=====================================
Hits 844 844
Misses 9591 9591
Partials 129 129 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
30730e9 to
f3d233d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This pull request closes #684 and refines error handling and improves code clarity in the
AgentRunnerandLLMProcessorclasses. The changes introduce a centralized error-handling mechanism inAgentRunner, remove redundant error-handling blocks inLLMProcessor, and enhance the processing of tool calls. Additionally, new imports were added to support these updates.Motivation
After reviewing the code, we found that
LLMProcessoris handling too many responsibilities beyond its core function, including error handling, abort signal processing, and system event creation. This creates role overlap withAgentRunnerand violates the Single Responsibility Principle.Changes
LLMProcessortoAgentRunnerLLMProcessorAgentRunnerAgentRunnerLLMProcessorto focus solely on LLM interactionBenefits
Checklist