Skip to content

fix: improve null safety and logging in main.ts #1811

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hobostay wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −14
Open

fix: improve null safety and logging in main.ts #1811

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 7 additions & 14 deletions apps/ui-tars/src/main/main.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -106,7 +106,12 @@ const initializeApp = async () => {
(source) => source.display_id === primaryDisplay.id.toString(),
);

callback({ video: primarySource!, audio: 'loopback' });
if (!primarySource) {
logger.warn('Primary display source not found, using first available source');
callback({ video: sources[0] || null, audio: 'loopback' });
} else {
callback({ video: primarySource, audio: 'loopback' });
}
});
},
{ useSystemPicker: false },
Expand Down Expand Up @@ -202,18 +207,6 @@ const registerIPCHandlers = (
return { unsubscribe };
};

/**
* Add event listeners...
*/

app.on('window-all-closed', () => {
// Respect the OSX convention of having the application in memory even
// after all windows have been closed
if (process.platform !== 'darwin') {
app.quit();
}
});

app
.whenReady()
.then(async () => {
Expand All @@ -231,4 +224,4 @@ app
logger.info('app.whenReady end');
})

.catch(console.log);
.catch(logger.error);