fix(tarko-agent-ui): render error in tool raw mode renderer#1659
Merged
Conversation
✅ Deploy Preview for tarko ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…rotection - Modified formatTimestamp to handle null/undefined timestamps at the type level - Removed fallback logic from RawModeRenderer components - Added proper type safety instead of runtime workarounds
…enderer - Restored formatTimestamp to original implementation - Added null checks in RawModeRenderer before calling formatTimestamp - Shows 'Unknown time' when timestamp is null/undefined - Prevents TypeError while maintaining proper separation of concerns
ulivz
changed the title
ulivz
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixed
TypeError: Cannot read properties of null (reading 'timestamp')error inRawModeRendererby adding null checks before callingformatTimestamp(). The component now properly handles cases wheretoolCall.timestamportoolResult.timestampmay be null/undefined, displaying 'Unknown time' as fallback text while maintaining proper separation of concerns.Checklist