feat(tarko-agent-cli): support unknown options passthrough#1574
Merged
Conversation
Enable allowUnknownOptions() for serve and run commands to support agent-specific CLI options like --aio-sandbox for agent-tars.
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Ensure unknown CLI options like --aio-sandbox are properly preserved and passed through to the agent configuration instead of being filtered out during destructuring.
…ssthrough Add test coverage for unknown CLI options preservation in buildAppConfig: - Basic unknown options preservation - Filtering of known CLI-only options - Complex data types support - Integration with user config and enhancers - Edge cases and comprehensive option coverage
…bility Replace hardcoded Set with structured destructuring approach: - Use single destructuring assignment for better readability - Group options by purpose (CLI-only, deprecated, filters) - Eliminate hardcoded option list maintenance burden - Preserve all functionality while improving code quality
…minimum - Use single destructuring assignment, no complex logic - Remove unnecessary Set and forEach loops - Clean up tests by replacing as any with toHaveProperty - Keep it simple: extract known options, rest goes to config - Maintain full functionality with minimal code
4 tasks
cjraft
approved these changes
Sep 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable
unknownOptionspassthrough for@tarko/agent-clito support agent-specific CLI options like--aio-sandbox.This allows commands like:
Then the Agent Constructor will receive following Agent Options:
Previously:
--aio-sandboxwould throwCACError: Unknown optionNow unknown options are properly passed through to the underlying agent implementation via
appConfig.Checklist