fix(tarko): preserve logo param in session routing#1471
Merged
Conversation
✅ Deploy Preview for agent-tars-docs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ulivz
force-pushed
the
fix/preserve-logo-param-in-session-routing
branch
from
c817164 to
b9e1c55
Compare
Create reusable hook for logo type management with automatic URL parameter persistence to localStorage.
ulivz
force-pushed
the
fix/preserve-logo-param-in-session-routing
branch
from
b9e1c55 to
c7aea40
Compare
Reduce from 50 lines to 15 lines, remove redundant code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the issue where
?logo=spaceparameter gets lost during session routing. ThelogoTypeinNavbar.tsxwas only computed once on mount:Now updates reactively when URL changes
Checklist